feat(entropy-tester): add retries #2855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
jayantk
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add retries to the entropy-tester script
Rationale
We use entropy-tester as a synthetic test for Entropy. If the script fails, it's a good signal that something is wrong. However, this can be a bit noisy, as currently a single failed callback raises an alarm, even though it is likely due to a transient chain issue we can't do anything about.
Adding retries to the tester allows us to reduce this noise by only alerting if we fail to receive multiple callbacks in a row. After this change, a critical alert will be fired if 3 callbacks fail back to back, giving us better confidence that something is actually wrong.
How has this been tested?